in theory, code review is a great idea because it means at least two people have seen code before it lands, which prevents silly errors and mistake that anyone can make.

in practice, code review in #FreeBSD means that you can't commit anything until your code has been reviewed by someone who works for Klara, Netgate, or Netflix.

because code review is unrewarding and time consuming, only people who are paid to do it will do it, which means all code is gated through a corporate representitive.

this is not really an ideal situation.

This entry was edited (1 month ago)