Skip to main content

Please make sure that you don't use atexit() in a library. Also, while at it, please no exit() or abort(). Thanks! atexit() related issues are insanely troublesome to correct after the use has been introduced. Case point: https://github.com/openssl/openssl/issues/22508 #development #coding #baddesign

3.0.12 broke pkcs11 engine · Issue #22508 · openssl/openssl

Hi, the testsuite for libp11-0.4.12 breaks in 3.0.12, works in 3.0.11. The testsuite: https://sources.debian.org/src/libp11/0.4.12-1/debian/tests/engine/ The segfault occurs while generating a cert...
GitHub
#development #coding #baddesign
in reply to daniel:// stenberg://

Billy O'Neal
Billy O'Neal
• •

@bagder all assertion failures, stack protector, unhanded exception, etc.

It’s true that abort shouldn’t be called in normal operation but by definition it isn’t normal operation

@daniel:// stenberg://
in reply to Billy O'Neal

daniel:// stenberg://
daniel:// stenberg://
• •
@malwareminigun if the library can crash the stack and trigger assertions then that is also a problem
@Billy O'Neal
in reply to daniel:// stenberg://

Harry Sintonen
Harry Sintonen
• •

@bagder @malwareminigun C++ exceptions are generally a no-no, since they are not ABI stable.

Also, another thing I generally dislike is using setjmp / longjmp - that is just bad design. Some image decoding libraries seem to think this is a acceptable way doing error handling.

@daniel:// stenberg:// @Billy O'Neal
in reply to daniel:// stenberg://

Billy O'Neal
Billy O'Neal
• •
@bagder the point is that calls to abort have to exist. Not that they are desirable in normal operation
@daniel:// stenberg://
in reply to Billy O'Neal

Billy O'Neal
Billy O'Neal
• •
@bagder (I argue that most things that would nominally return EINVAL should be aborts but :shrug:)
@daniel:// stenberg://
in reply to Billy O'Neal

daniel:// stenberg://
daniel:// stenberg://
• •
it's not the library's job to abort, that's the application's job
This entry was edited (6 months ago)
in reply to daniel:// stenberg://

Billy O'Neal
Billy O'Neal
• •
@bagder The problem is that often a lot of the context is lost in trying to report that to the application. If app A calls library B calls library C, and C says EINVAL which gets returned by B to A, where the bug is is not clear
@daniel:// stenberg://
⇧