Skip to main content

Welcome Sam James as #curl committer 1217: github.com/curl/curl/pull/1229… (yes, that's the silliest gcc warning introduced in a long time IMHO)

Fix -Walloc-size by thesamesam · Pull Request #12292 · curl/curl

GCC 14 introduces a new -Walloc-size included in -Wextra which gives: src/tool_operate.c: In function ‘add_per_transfer’: src/tool_operate.c:213:5: warning: allocation of insufficient size ‘1’ for ...
GitHub
#curl
in reply to daniel:// stenberg://

Jonathan Yu
Jonathan Yu
• •
Why's it a silly warning? Because the amount of memory being allocated is the same? 480 count of 1 byte vs 1 count of 480 bytes? I guess it doesn't make a difference in practice, but it still seems nice to have the function call match the prototype arguments, right?
in reply to Jonathan Yu

daniel:// stenberg://
daniel:// stenberg://
• •
@jawnsy because it does not help. Because we have written fine code like this for decades already. Pointless.
@Jonathan Yu
in reply to daniel:// stenberg://

sven
sven
• •
@jawnsy
I guess it's only silly if you know the implementation and *know* it makes no difference. Even then, the implementation might change, breaking your code
@Jonathan Yu
⇧