Not sure whether this works for curl: Formal checks of the commit message can be nicely automated with GitHub actions so that the contributor gets instant feedback. OpenJDK uses this heavily on their repos.
Oh how I wish GitHub would allow fast-forward merges. I would love to force-push a PR with a corrected commit message and then FF merge. Bitbucket allows this!
@jornfranke We have support for manual merges. The detection is still not perfect, but works in most cases, and you can always provide the commit id that merged a PR instead of pressing the merge button if it failed for some reason.
The option is "Enable autodetect manual merge (Note: In some special cases, misjudgments can occur)" in the Pull requests repo settings. @bagder
Marc R. Hoffmann
in reply to daniel:// stenberg:// • • •daniel:// stenberg://
in reply to Marc R. Hoffmann • • •Francis 🏴☠️ Gulotta
in reply to daniel:// stenberg:// • • •gigantos
in reply to daniel:// stenberg:// • • •not sure your suggested solution would work, as the merged state makes some promises afaik.
You can access the pull request with a .patch suffix, and this will give you a valid patch file for said pull request.
However, with your approach this promise would no longer hold.
daniel:// stenberg://
in reply to gigantos • • •gigantos
in reply to daniel:// stenberg:// • • •ah, yeah. If they link it to the actual commit, the patch is still correct.
Doh. Sorry for wasting your time
James O'Gorman
in reply to daniel:// stenberg:// • • •daniel:// stenberg://
in reply to daniel:// stenberg:// • • •Why curl closes PRs on GitHub | Hacker News
news.ycombinator.commanchicken moved!
in reply to daniel:// stenberg:// • • •Jörn Franke
in reply to daniel:// stenberg:// • • •Codeberg.org
in reply to Jörn Franke • • •@jornfranke
We have support for manual merges. The detection is still not perfect, but works in most cases, and you can always provide the commit id that merged a PR instead of pressing the merge button if it failed for some reason.
The option is "Enable autodetect manual merge (Note: In some special cases, misjudgments can occur)" in the Pull requests repo settings.
@bagder
daniel:// stenberg://
in reply to Codeberg.org • • •