mastodon - Link to source

Jamie Teh

3 weeks ago

Jamie Teh
3 weeks ago

In today's episode of #accessibility shit-fuckery, GitHub have changed pull request reviews so that you have to hover the line of code in order for the add line comment button to appear. I guess they must be using AI for all their code now as their CEO believes is right and proper, and they forgot to disable the AI's ableism.

#Accessibility

in reply to Jamie Teh

mastodon - Link to source

Dickson Tan

in reply to Jamie Teh 3 weeks ago

I always thought it worked that way and the Greasemonkey script fixed it. Did the buttons previously always appear even without the script installed?

Hate how everyone is going mad over AI, or maybe AI is just amplifying the problems it picked up in the code it got trained on.

in reply to Dickson Tan

mastodon - Link to source

Jamie Teh

in reply to Dickson Tan 3 weeks ago

@neurrone Nope, they were at least always in the accessibility tree and I'm pretty sure they were visible too. AxSGrease workaround incoming.

@Dickson Tan

in reply to Jamie Teh

mastodon - Link to source

Dickson Tan

in reply to Jamie Teh 3 weeks ago

Thanks a lot!

Its sad they can't even get basic stuff like this right. I thought they had people at least looking at accessibility, this was the most recent blog post I saw.

github.blog/engineering/user-e…

Building a more accessible GitHub CLI - The GitHub Blog

How do we translate web accessibility standards to command line applications? This is GitHub CLI's journey toward making terminal experiences for all developers.

^{Ryan Hecht (The GitHub Blog)}

in reply to Jamie Teh

mastodon - Link to source

Jamie Teh

in reply to Jamie Teh 3 weeks ago

@neurrone The script always moved the button to after the line instead of before it.
Obviously, I have no evidence that this was an AI fail. I was just being snarky given the GitHub CEO's recent assertion that developers should quit the software business if they aren't using AI.

@Dickson Tan

in reply to Jamie Teh

mastodon - Link to source

Dickson Tan

in reply to Jamie Teh 3 weeks ago

I've reinstalled the script and it works.

I get the sarcasm, but I honestly wouldn't be surprised if there was a grain of truth. Priorities are shifting to AI, and everything else gets sidelined.

in reply to Jamie Teh

mastodon - Link to source

Sascha Cowley

in reply to Jamie Teh 3 weeks ago

I've just modified my accessGrease script to slap a display: block on the "add line comment" button haha. Was the quickest workaround I could think of to get back to work

in reply to Sascha Cowley

mastodon - Link to source

Jamie Teh

in reply to Sascha Cowley 3 weeks ago

@saschacowley I just landed that exact change on the master branch. :)

@Sascha Cowley

in reply to Jamie Teh

mastodon - Link to source

Sascha Cowley

in reply to Jamie Teh 3 weeks ago

Nice! I'll be interested to see how our approaches differ, given I assume you're more of a JS native speaker than me

in reply to Sascha Cowley

mastodon - Link to source

Sascha Cowley

in reply to Sascha Cowley 3 weeks ago

You should merge my PR to the GitHub script. It makes the filenames in the PR review interface headings

in reply to Sascha Cowley

mastodon - Link to source

Jamie Teh

in reply to Sascha Cowley 3 weeks ago

@saschacowley I agree that's a necessary change. I think I commented on your PR with some issues though? Need to look again.

@Sascha Cowley

in reply to Jamie Teh

mastodon - Link to source

Sascha Cowley

in reply to Jamie Teh 3 weeks ago

Oh huh, I don't remember seeing them. For what it's worth, I've been using the code I submitted daily since before that PR was opened :)

in reply to Sascha Cowley

mastodon - Link to source

Jamie Teh

in reply to Sascha Cowley 3 weeks ago

@saschacowley You never saw them because I apparently never commented and there wasn't anything to comment about other than nits. Sorry, not sure what happened there. I guess I got snowed under with other things and just never got to it, which is a poor excuse. :( Anyway, merged now. Thank you.

@Sascha Cowley

in reply to Jamie Teh

mastodon - Link to source

Sascha Cowley

in reply to Jamie Teh 3 weeks ago

No problem at all. I was going to resolve merge conflicts but I guess you already did that

in reply to Sascha Cowley

mastodon - Link to source

Jamie Teh

in reply to Sascha Cowley 3 weeks ago

@saschacowley Yeah, I figured that was the least I could do given how long I let this lapse, haha.

@Sascha Cowley

in reply to Jamie Teh

mastodon - Link to source

Léonie Watson

in reply to Jamie Teh 3 weeks ago

Hitting Enter on the line of code you want to comment on does the trick by the looks of things.

in reply to Léonie Watson

mastodon - Link to source

Jamie Teh

in reply to Léonie Watson 3 weeks ago

@tink Do you mean it opens the comment editor or it makes the button appear? It does the latter here, but that's still not ideal because it requires 2 actions instead of 1. Still better than nothing though. I've hacked around this in AxSGrease now so the button is always present.

@Léonie Watson

in reply to Jamie Teh

mastodon - Link to source

Léonie Watson

in reply to Jamie Teh 3 weeks ago

It opens a modal with focus in an edit field for adding a comment. Which button are you referring to?

in reply to Léonie Watson

mastodon - Link to source

Jamie Teh

in reply to Léonie Watson 3 weeks ago

@tink Here, pressing enter on a line of code in browse mode does nothing. I think it sometimes causes the add line comment button to appear, but I then have to navigate to that and press it.

@Léonie Watson

in reply to Jamie Teh

mastodon - Link to source

Léonie Watson

in reply to Jamie Teh 3 weeks ago

Ah! That's the difference I think. I've been browsing the diff tables in applications mode rather than browse mode.

in reply to Léonie Watson

mastodon - Link to source

Jamie Teh

in reply to Léonie Watson 3 weeks ago

@tink The thing is that I can't use this in focus mode. There just isn't anything focusable to... wel, focus. I wonder if this is one of those half rolled out things where they've rolled bits of it out at a time, not accounting for the fact that rolling some of it out without the rest of it actually causes problemsfor some users.

@Léonie Watson

in reply to Jamie Teh

mastodon - Link to source

Patrick H. Lauke

in reply to Jamie Teh 3 weeks ago

@tink i believe the problem is that the new behaviour (navigating through the diff table like a grid, then using enter to bring up the plus button) is only present in the "try the new experience" preview. if you're still in the old version, that's now apparently been removed.

@Léonie Watson

in reply to Jamie Teh

mastodon - Link to source

Léonie Watson

in reply to Jamie Teh 3 weeks ago (Received 2 weeks ago)

Interesting. So the whole thing is a grid so you should be able to Tab into it, then use the arrow keys to navigate it. I wonder if it isn't working cross-platform/screen reader? I'm using Jaws/Firefox.

in reply to Léonie Watson

mastodon - Link to source

Patrick H. Lauke

in reply to Léonie Watson 3 weeks ago (Received 2 weeks ago)

@tink as mentioned, the grid thing is only in the "Try the new experience" preview that you need to opt into. in the default view, it's just a regular table with no focusable bits

@Léonie Watson

in reply to Patrick H. Lauke

mastodon - Link to source

Jamie Teh

in reply to Patrick H. Lauke 2 weeks ago

@patrick_h_lauke @tink It's weird that the hover change apparently graduated into the non-preview experience (making it effectively inaccessible), but the focusable grid is still in preview. I'm not particularly surprised, but.... 😩

@Léonie Watson @Patrick H. Lauke

in reply to Jamie Teh

mastodon - Link to source

Florian

in reply to Jamie Teh 3 weeks ago

The idea is to press enter on a line of code, which then brings up a thing that lets you add a comment. If there are already comments that will bring them up in a browseable modal as well, and if you hold shift and use the arrow keys to select multiple lines and THEN hit tab to get to the "more actions"thing, you can now make a multiline comment. THis is clearly still being worked on so why this is live right now is beyond me, but there you go

in reply to Florian

mastodon - Link to source

Jamie Teh

in reply to Florian 3 weeks ago

@zersiax Do you mean press enter on a line of code in browse mode? Or do you have to focus it somehow? Pressing enter when my browse mode cursor is on code does nothing immediate here.

@Florian

in reply to Jamie Teh

mastodon - Link to source

Florian

in reply to Jamie Teh 3 weeks ago

in focus mode. once you tab onto the grid your arrows move between the cells in the table, or ... at least ... that is what should happen I believe

in reply to Florian

mastodon - Link to source

Jamie Teh

in reply to Florian 3 weeks ago

@zersiax So weird. I cannot tab to the grid here at all. It just isn't focusable. I wonder if this is one of those things that is "rolling out", except they rolled out the hover change before they rolled out the keyboard accessibility bit?

@Florian

in reply to Jamie Teh

mastodon - Link to source

Dickson Tan

in reply to Jamie Teh 3 weeks ago

@zersiax That doesn't work for me as well. I tried pressing enter on the line or entering focus mode.

@Florian

in reply to Jamie Teh

mastodon - Link to source

Steve

in reply to Jamie Teh 3 weeks ago

I was wondering why I couldn't comment on files in pull requests anymore. Good going, ass hats. #github #accessibility #fail

#Accessibility #github #fail

⇧